Skip to content

[bug] tx pull issue if string contains href=" #259

Description

@mmattel

tx 1.6.17 (latest at the time of writing)

  1. Prepare a directory for pulling and initialize it.
  2. Then pull using tx pull -s -t -all

All strings that contain href= will be downloaded with unescaped special characters:

Example:

Source:
<![CDATA[ Fragen Sie für Hilfe in unserem <a href=\"%1$s\"><b>Forum</b></a> oder machen Sie einen Beitrag in unserem <a href=\"%2$s\"><b>GitHub repo</b></a>]]>

Downloaded:
<![CDATA[ Fragen Sie für Hilfe in unserem <a href="%1$s"><b>Forum</b></a> oder machen Sie einen Beitrag in unserem <a href="%2$s"><b>GitHub repo</b></a>]]>

As you can see, escaping the double quote was removed from the string on all locations.
Strings that contain escaped characters but do not contain href= are not affected !!

To push the pulled resource e.g. to another project will now fail, because push does not allow unescaped special characters.
You have to manually reapply escaping to let push succeed.

Expectation:
tx MUST NOT remove the escaping character from any location in the string if href= is present

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions