Conversation
treeform
requested changes
Dec 5, 2025
Return the default X11 screen as the primary screen so Linux callers can use the same API as the other platforms.
relh
force-pushed
the
feature/linux-getScreens
branch
from
July 22, 2026 21:36
dd667e9 to
5db2a77
Compare
relh
commented
Sep 9, 2026
relh
left a comment
Contributor
Author
There was a problem hiding this comment.
[Codex, acting on behalf of relh]
Reviewed 5db2a77. The screen-enumeration concern in André's existing inline review remains unresolved: defaultScreen still produces one aggregate X11 screen rather than all attached monitors. The example's Linux guard has been removed, so that separate comment has been addressed. No additional distinct finding. I reviewed the current diff and existing thread; I did not run a multi-monitor X11 session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Games need each monitor’s position and size to place a window on the chosen display. The old change returned one rectangle covering the desktop, so it could not distinguish two monitors.
Use RandR 1.5 to return active monitor rectangles and their primary flags. This requires libXrandr and a server supporting RandR 1.5. The example prints the result on every supported platform, including the browser.
Validation: on a real Xvfb server configured with two 800 by 600 monitor regions, the old code returned one 1600 by 600 rectangle. The new test returns two distinct rectangles. A rendered check used those bounds to place two colored windows, one inside each region. This is virtual-monitor runtime evidence, not a physical multi-monitor or hot-plug test. The regression runs in the existing Linux CI job.
Updated to current upstream master. Addresses the existing request to return every screen.
The implementation checks passed on Linux, macOS, and Windows. The final change only moves this test step beside the screen example so it combines with the pending VSync PR; its final run has also passed on all three platforms. The runtime limits above still apply.