Report malformed tree entries as object corruption - #670
Open
betacatsling wants to merge 3 commits into
Open
betacatsling wants to merge 3 commits into
betacatsling wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 72.42% 74.33% +1.90%
==========================================
Files 67 66 -1
Lines 5132 5431 +299
Branches 605 624 +19
==========================================
+ Hits 3717 4037 +320
+ Misses 1227 1198 -29
- Partials 188 196 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
betacatsling
force-pushed
the
fix/malformed-tree-errors
branch
from
September 12, 2026 06:53
f02e62a to
b2ad403
Compare
betacatsling
force-pushed
the
fix/malformed-tree-errors
branch
from
September 12, 2026 06:57
b2ad403 to
27a678e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree.load()classifies JSON decoding failures as corrupt objects but lets malformed list entries escape asKeyError,AttributeError,TypeErrororValueError. Callers such as_try_load()then stop instead of trying another database.Translate those entry-deserialization errors into
ObjectFormatError, preserving the cause. Tests cover malformed entry structures and a real two-database fallback from a corrupt manifest to a valid copy. All five regressions fail on the unchanged base.Validation on Linux/Python 3.12: 196 tests passed, 32 skipped; Ruff format/lint, project mypy and diff checks passed. No remote storage calls were used. AI assistance was used for implementation and verification.
Prerequisite and revalidation: this branch now includes the shared CLI compatibility fix in #672 (4551489) followed by the original focused patch. This lets a fresh
[tests,cli]installation run without external Click. The common change is separately reviewable and will disappear from this PR's diff once #672 is merged.Revalidated the combined branch on Python 3.12 / Typer 0.27.2 with external Click absent: 202 passed / 32 skipped, mypy passed, and full source/test lint plus formatting passed with the repository-pinned Ruff 0.15.2. The benchmark workflow's base-branch step still needs #672 merged to main; it runs before the PR's code.
Fixes #669.