Repository navigation
URL-encode link-patterns destinations - #749
Conversation
Fixes trentm#55 Signed-off-by: Don Yin <Don_Yin@outlook.com>
Signed-off-by: Don Yin <Don_Yin@outlook.com>
| Python-markdown (markdown.py). | ||
| """ | ||
|
|
||
| def test_link_pattern_url_encoding(self): |
There was a problem hiding this comment.
This should go as a test file in test/tm-cases. Better error formatting
There was a problem hiding this comment.
Moved it to test/tm-cases/link_patterns_url_encoding.*.
Signed-off-by: Don Yin <Don_Yin@outlook.com>
…coding Signed-off-by: Don Yin <Don_Yin@outlook.com> # Conflicts: # CHANGES.md
|
@Crozzers ill let you have final say |
|
Looks fine. |
|
Thanks for looking! I don't think it changes anything in practice: with |
Fixes #55.
link-patternswrote the generated destination intohrefas is, so a pattern producing a target with spaces gavehref="lorem foo bar ipsum". I URL-encode it withurllib.parse.quote, keeping URL delimiters and existing%escapes, so normal URLs come out unchanged.I added a test for the case in the issue. The full test suite and
make testredospass locally.