Skip to content

fix: remove unused variable and dead code warnings - #447

Merged
Ziinc merged 2 commits into
mainfrom
claude/fix-unused-variable-warnings-q94ezw
Sep 10, 2026
Merged

Ziinc merged 2 commits into
mainfrom
claude/fix-unused-variable-warnings-q94ezw

Conversation

@Ziinc

@Ziinc Ziinc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

This PR cleans up unused code in the codebase by removing unused parameters and eliminating dead code.
Key changes:

  • Prefixed unused operation parameters with underscore in IdempotencyStore methods (reclaim_stale, claimed_at, complete, and abandon) to suppress compiler warnings while maintaining the method signatures for API compatibility
  • Removed the unused enabled() function from feature_preview.rs command module, which was a wrapper around feature_preview::is_enabled() that was not being called anywhere
    These changes improve code cleanliness by eliminating compiler warnings and removing unreachable code without affecting the public API or functionality.
    https://claude.ai/code/session_016cWEgf7mftVW9Nex9sxvN8

@Ziinc Ziinc changed the title Remove unused parameters and dead code from idempotency and feature preview fix: remove unused variable and dead code warnings Sep 10, 2026

Ziinc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

verify / verify / ubuntu-22.04 is failing on the max-lines lint rule for test/integration/workspace/create-pr.test.tsx (563 lines, limit 500). This file isn't touched by this PR's diff (only src-tauri/src/core/idempotency_store.rs and src-tauri/src/commands/feature_preview.rs change here), and the same failure reproduces on main at HEAD (5396f43) — confirmed by checking the file there directly. No fix PR exists yet for it. Re-running this job won't help since it's a deterministic lint failure, not a flake, so I'm not spending the one re-run on it.


Generated by Claude Code

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Ziinc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

js / test:integration / ubuntu-22.04 is failing on test/integration/filepicker.test.tsx > opens via Ctrl+P, shows initial state, searches files, and selects a result — a 5000ms test timeout. This test file isn't touched by this PR's diff, and the same test failed identically (same line, same timeout) on both the pre-merge run and the post-merge run of this PR, so it isn't a one-off flake tied to my changes. No fix exists for it yet upstream. Not spending the re-run here since it already reproduced twice independently.


Generated by Claude Code

Ziinc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

rust / test / windows-latest is failing on 5 Windows-only tests: commands::pty_commands::tests::resolves_workspace_id_to_absolute_working_directory and 4 jj::tests::reconcile_* cases. None of these touch the code this PR changes (idempotency_store.rs, feature_preview.rs), and the same 5 tests failed identically (same names, same failure) on both the pre-merge and post-merge CI runs of this PR — so it isn't a flake introduced by this change. No fix exists for it yet upstream. Not spending the re-run since it already reproduced twice independently.


Generated by Claude Code

claude and others added 2 commits September 11, 2026 02:19
Prefix unused operation params in idempotency_store with underscore,
and remove the unused feature_preview::enabled command helper.
@Ziinc
Ziinc force-pushed the claude/fix-unused-variable-warnings-q94ezw branch from 760cc46 to c065659 Compare September 10, 2026 18:23
@Ziinc
Ziinc merged commit b68ffd9 into main Sep 10, 2026
19 of 21 checks passed
@Ziinc
Ziinc deleted the claude/fix-unused-variable-warnings-q94ezw branch September 10, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants