Skip to content

fix: Kill a Python backend stub that outlives a failed instance launch #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
an1310 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Kill a Python backend stub that outlives a failed instance launch #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/stub_launcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,12 +539,25 @@ StubLauncher::Launch()
stub_message_queue_->Push(DUMMY_MESSAGE);
}

// If the model is not initialized, wait for the stub process to exit.
// If the model is not initialized, make sure the stub process exits. A
// stub that reported an initialization error normally exits on its own. A
// stub the server gave up on, for example after missed health updates,
// may still consider itself initialized and would wait for commands
// forever, so a stub that has not exited when the stub timeout expires is
// killed.
if (!is_initialized_) {
stub_message_queue_.reset();
parent_message_queue_.reset();
memory_manager_.reset();
WaitForStubProcess();
if (!WaitForStubProcessWithTimeout(stub_timeout_seconds_)) {
LOG_MESSAGE(
TRITONSERVER_LOG_WARN,
(std::string("Python backend stub '") + model_instance_name_ +
"' did not exit within " + std::to_string(stub_timeout_seconds_) +
" seconds after its initialization failed; killing it.")
.c_str());
KillStubProcess();
}
}
});

Expand Down