Skip to content

add Vietnamese language - #330

Open
MinhAnime wants to merge 1 commit into
tryliner:mainfrom
MinhAnime:minhanime/lang-vi
Open

MinhAnime wants to merge 1 commit into
tryliner:mainfrom
MinhAnime:minhanime/lang-vi

Conversation

@MinhAnime

@MinhAnime MinhAnime commented Oct 29, 2026 •

Copy link
Copy Markdown

What

Add Vietnamese language

Why

How

Checklist

  • pnpm check passes
  • Follows AGENTS.md: no comments in code, files under 150 lines, imports only point down the FSD layers, no any
  • Screenshot or recording attached for UI changes
  • Tested in the running app, not only in unit tests
  • docs/PRIVACY.md updated if this changes what the app sends off the device
  • New strings added to en.json (other languages are optional)

Summary by CodeRabbit

  • New Features
    • Added Vietnamese as a supported app language, with translated interface text and a Vietnamese option in language settings.
    • Vietnamese browser locales, such as vi-VN, are now recognized as Vietnamese.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 291641e and 7680558.

Files selected for processing: 7
  • docs/I18N.md
  • src/languages/data.ts
  • src/languages/locale.test.ts
  • src/languages/locale.ts
  • src/languages/locales/vi.json
  • src/languages/options.tsx
  • src/languages/translator.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

Adds Vietnamese translations and registers vi as a supported, selectable locale. Browser locale resolution maps vi-VN to vi. Tests check a Vietnamese library label and pluralized track string.

Changes: Vietnamese locale support

Layer / File(s) Summary
Add and register Vietnamese translations
src/languages/locale.ts, src/languages/locales/vi.json, src/languages/data.ts, src/languages/options.tsx, src/languages/locale.test.ts, src/languages/translator.test.ts, docs/I18N.md
Adds Vietnamese translations, registers vi as a supported locale and language option, and updates tests and documentation.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: feralbureau, flowsinecode

Merge Risk: Minimal · up to 76805

Vietnamese is registered for selection. No merge-blocking issue was identified; run the normal checks before merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding Vietnamese language support.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 5 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant