Repository navigation
Conversation
The code and JS executor pods were inheriting a *_SERVICE_HOST/*_PORT env var for every Service in their namespace, which they don't use, and shouldn't see.
Contributor
 [Low impact] The PR appears safe to merge; no actionable failures were found. Reviews (1) · Last reviewed commit: "Disable service links on executor pods" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
enableServiceLinks: falseon the code executor and JS executor pod specs.Both pods were inheriting a
*_SERVICE_HOST/*_PORTenv var for every Service in their namespace, which neither service reads, and which execution environments shouldn't see. Same treatment the agent sandbox pods received in #410.KUBERNETES_SERVICE_HOSTis unaffected by this setting.Test plan: rendered the chart with
ci/test-install-values.yamlplusci/test-js-executor-enabled-option.yaml; both the code-executor and js-executor Deployments haveenableServiceLinks: falsein their pod spec.