Skip to content

Update circuit-to-svg to 0.0.453 and refresh SVG snapshots - #4825

Merged
ShiboSoftwareDev merged 1 commit into
tscircuit:mainfrom
rushabhcodes:chore/update-circuit-to-svg-0.0.453
Oct 21, 2026
Merged

ShiboSoftwareDev merged 1 commit into
tscircuit:mainfrom
rushabhcodes:chore/update-circuit-to-svg-0.0.453

Conversation

@rushabhcodes

@rushabhcodes rushabhcodes commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Update circuit-to-svg from ^0.0.450 to the latest npm release, ^0.0.453, which fixes rotated polygon plated holes and PCB bounds for traces containing vias.

Refresh the schematic display-label and SOIC8 fanout phase SVG baselines found by the full snapshot run. These two baselines also differed under 0.0.450; comparing both renderer versions produced identical updated output.

Validation:

  • bunx tsc --noEmit and bun run build passed locally.
  • Regenerated snapshots across all 1,794 test files. The HDMI routing fixture exceeded its 300-second local timeout, including on a focused retry; the unchanged fixture passed in CI in 153 seconds.
  • Five snapshot-related test files passed without snapshot updates, including the three assembly fixtures whose existing PNGs remain within tolerance.
  • GitHub CI passed all 10 test jobs, typecheck, distribution smoke tests, dependency checks, and package preview.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Oct 21, 2026 2:11pm UTC

Request Review

@rushabhcodes
rushabhcodes marked this pull request as ready for review October 21, 2026 14:16
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Devesh36 Devesh36 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains a same snapshot correction for example10-schDisplayLabel that #4811 missed and now is causing ci failures in existing pr's

@ShiboSoftwareDev
ShiboSoftwareDev merged commit 8c671d5 into tscircuit:main Oct 21, 2026
22 checks passed
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


This branch was successfully deployed

1 active deployment
Preview — 46fe32a7 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants