Repository navigation
Document remaining-routing preflight and its 50-connection threshold - #1019
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
techmannih
left a comment
There was a problem hiding this comment.
The 50/51 threshold is correct. One sentence overstates the scope of the policy.
|
The limit applies to connections still waiting for the implicit routing phase. With the default settings, 50 remaining connections route. With 51, the whole implicit phase is skipped and core reports a routing error. Setting You can also see the boundary with 52 total connections. Route one explicitly and 51 remain, so only the first routes. Route two explicitly and the remaining 50 also route. This PR documents existing core behavior. Executable cases |
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
The board reference previously described omitting
routeRemainingand explicitly setting it totrueas equivalent. Under the default preflight, the implicit routing phase runs only when 50 or fewer connections remain after explicit phases finish.routeRemainingomittedrouteRemainingomittedrouteRemaining={true}This PR updates the documentation for existing core behavior. The regression also covers explicit overrides and nested subcircuits. Core regression · Preview the corrected board properties reference
To reproduce in a core checkout, run
bun test tests/features/board-route-remaining-preflight.test.tsx.