Repository navigation
Expose CAD component placement transforms with named inputs - #3
Merged
Merged
Conversation
seveibar
changed the title
This was referenced Sep 23, 2026
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
CadComponentPlacementandtransformCadComponentPlacementfor transforming CAD position/rotation before the database record exists. Existing records usetransformCadComponent. Both take named function inputs first and the sharedCadFoldContextsecond, following the handbook.Use explicit
cadComponentandcadComponentPlacementnames. Convert the remaining flex-utils helpers with more than two arguments to named arguments, including polygon extrusion and stiffener generation; update the documented API.Validation: ten tests (1,032 assertions), type checking and build pass. An AST check verifies every flex-utils function has at most two parameters. Core, viewer and GLTF call sites are updated in their dependent PRs and pass focused tests/type checking against this build.