Repository navigation
Conversation
seveibar
changed the title
seveibar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by jscad-electronics #504, which retains and reads native JSCAD profiles/paths alongside the actual solid and includes visual model and drawing snapshot coverage.
The endpoint metadata approach in this PR is withdrawn. Modelprinter keeps responsibility for model strings, parameter schemas, dimensions, defaults and validation. Edge geometry/topology belongs to the model implementation and its STEP/glTF/JSCAD reader.
The dimension proposal in props #953 retains model-defined
edgeRefselectors and explicitwidthOfView/heightOfViewpresets. Circuit JSON #922 now carries onlycad_component_idplus an opaqueedge_name, with no edge geometry records. Exporter #3 consumes model-reader results outside Circuit JSON.