Repository navigation
Accept an explicit model on assembly.cable #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7bbdefc
Add bullet connector and assembly cable props
seveibar f165269
Allow grouped bullet connectors with one to sixteen contacts
seveibar b508cfa
Document named bullet cable diameter and endpoint gender modifiers
seveibar e2cd4ec
Expose named bullet cable connectors on imported CAD assemblies
seveibar bc671a1
Keep expected CAD connector literal types precise in schema tests
seveibar 813a9f6
Document generic adapter cables with independent connector ends
seveibar ee57239
Merge current props and regenerate adapter cable documentation
seveibar 5f09a99
Accept physical connector model strings independently of standards
seveibar e3d0f5e
Use model for physical connector specifications
seveibar 30c249f
Keep connector model data in model strings
seveibar 1c96d90
Limit cable props change to an explicit model
seveibar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
*.test.tsfile may have AT MOST onetest(...)call. The fileassembly-cable.test.tsalready contained at least onetest(...)before this diff, and this change adds another one ("assembly.cable accepts an explicit model without changing standard behavior"). Per the style guide, once a second test is needed the tests must be split into multiple numbered files, e.g.assembly-cable1.test.ts,assembly-cable2.test.ts. Please move this new test into its own numbered file.Spotted by Graphite (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.