Repository navigation
Reproduce off-wire inline label attachment points - #1344
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
added this pull request to stack #1346
October 21, 2026 07:04
MustafaMulla29
force-pushed
the
repro/inline-label-wire-anchors
branch
from
October 21, 2026 10:32
c35b3df to
ab78a4e
Compare
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce inline attachment points falling off bent wires in core's existing TB67S579FTG breakout. Only J4's schematic position changes, from
(7, -0.4)to(4.6, 0.5); the captured solver input retains the original components and connections.The test generates an overview and a close-up of OUT_A_P / OUT_B_P. Dashed boxes show the solver's actual text bounds, and blue dots show its returned
anchorPoint. On the current implementation, both dots are 0.1 mm off their wires. The guides usegraphics-debugonly in the test and do not change routing or placement.The repro also includes a vertical layout of the same TB67 circuit, captured from a layout variant of core's existing
repro-tb67s579ftg-inline-net-labels.test.tsxcircuit. Components and connections are unchanged; normal schematic layout props place the pin rows at the top/bottom and J4 above U1. Openrepro-core-tb67s579ftg-vertical-inline-label-attachments-detail.snap.svg: both blue attachment points are 0.1 mm off their wires before the fix.This PR records the current behavior and passes without the fix. It adds the regression tests, captured inputs, and snapshots without changing the solver implementation. The fix in #1339 will be stacked on this branch, adding on-wire assertions and updating these same snapshots so reviewers can see the points move onto the wires while the text boxes stay in place.
Validation: the repro test and
bunx tsc --noEmitpass on the unmodified solver implementation.Straight vertical terminal coverage:
repro-core-tb67s579ftg-vertical-inline-label-attachments-straight-stub.snap.svgshows AGC_OUT from that same captured input, with the text bounds and attachment point. Its attachment is already on the straight wire on main, so this snapshot is unchanged by #1339.