[pull] master from ruby:master - #1346
Merged
Merged
Conversation
… header format release_date_for in spec/support/build_metadata.rb matched the changelog's old `## VERSION (DATE)` header, but .changelog.yml has generated `## VERSION / DATE` headers since Bundler 4.0.9. The regex silently failed to match, so built_at was baked as nil into every release since, and Bundler::BuildMetadata.timestamp fell back to Time.now.utc on every invocation — `bundle version` always showed today's date instead of the real release date. spec/support/build_metadata.rb is release tooling for the bundler:build_metadata rake task, not part of the RSpec bundler suite; spec_helper.rb never requires it. The sibling release script tool/changelog.rb already has its test in test/test_changelog_generator.rb, so the regression test for this lives in test/test_build_metadata_generator.rb to match. ruby/rubygems@b69384e96b Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The fixture changelog still used the old `## VERSION (DATE)` header, so the fixed `release_date_for` no longer matched it and the released case of the version spec failed. ruby/rubygems@36ee802a7e Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the Style/RegexpLiteral offense from CI. ruby/rubygems@c4069df44d Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…undaries The basename was cut with byteslice, which can split a multibyte character in half. Filesystems enforcing UTF-8 validity such as APFS then reject the temporary name with EILSEQ. ruby/rubygems@a7dc5647b0 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e destination The temporary file was renamed into place before being closed, so buffered data had not reached the filesystem yet and a concurrent reader could observe an empty destination. A flush failure such as ENOSPC would surface only after the destination had already been replaced. Cleanup also moved to an ensure block, so an interrupt no longer leaks the temporary file. ruby/rubygems@774bd08837 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Arrays sharing one buffer have the same data pointer, so rb_ary_splice() took `a` in `b = a.dup; b.pop; b.concat(a)` for `b` itself and rebased the source onto `b`'s shorter storage, copying uninitialized memory. Have the callers tell whether the replacement really is `ary`. [Bug #22259] Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Most callers have the replacement as an array object; let them pass it directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )