Repository navigation
Return an error from DynamicSelectOneResponse when its options are not [value, label] pairs - #349
Merged
joaothallis merged 1 commit intoOct 13, 2026
Conversation
…t [value, label] pairs
DynamicSelectOneResponse.update_config/4 mapped over the evaluated
choice_expression assuming every element is a [value, label] pair. When the
list the options are built from is missing, Expression returns its error map
instead, and the block raised a FunctionClauseError in the caller's process.
It now returns {:error, reason} from evaluate_incoming/4, which the
FlowRunner.Spec.Block callback already allows.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DynamicSelectOneResponseassumes every option itschoice_expressionreturns is a[value, label]pair. When the list the options are built from is missing, Expression returns its error map instead, and the block raises aFunctionClauseErrorin the caller's process.Approach
evaluate_incoming/4now returns{:error, reason}when the options are not a list of[value, label]pairs, which theFlowRunner.Spec.Blockcallback already allows.🤖 Generated with Claude Code