Conversation
baltpeter
requested changes
Nov 25, 2024
baltpeter
previously approved these changes
Nov 25, 2024
baltpeter
left a comment
baltpeter
left a comment
Member
There was a problem hiding this comment.
I haven't tested this but it looks good. If you want me to test, it'll have to wait until tomorrow. Otherwise, feel free to merge and release.
It turns out warnings are good for something. We needed to remove the listeners if a timeout completes sucessfully, see nodejs/node#35990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor to tweaselORG/cyanoacrylate#55.