Conversation
smnandre
reviewed
Sep 27, 2026
Comment on lines
+58
to
+61
| The reference is how Twig behaves, not how the documentation describes it. When | ||
| they disagree, the documentation is wrong and gets fixed. Only when the | ||
| documented behavior is the one Twig intended is Twig fixed instead, which can | ||
| change the output of Twig templates relying on the previous behavior. |
Contributor
There was a problem hiding this comment.
This feels harder to read than it could/should
Especially the
is the one Twig intended is Twig fixed instead
smnandre
reviewed
Sep 27, 2026
| documented behavior is the one Twig intended is Twig fixed instead, which can | ||
| change the output of Twig templates relying on the previous behavior. | ||
|
|
||
| The promise does not cover: |
Contributor
There was a problem hiding this comment.
I think i would move the "does not cover" near the "does cover" and would precise the edge cases after both
smnandre
reviewed
Sep 27, 2026
Comment on lines
+139
to
+146
| Deprecated Code | ||
| ~~~~~~~~~~~~~~~ | ||
|
|
||
| When a class, a method or an extension point is going to be removed or | ||
| changed, Twig deprecates it in a minor release and triggers a deprecation | ||
| notice when your code uses it. The :doc:`deprecated features <deprecated>` page | ||
| lists all deprecations with their replacement; fix them before upgrading to the | ||
| next major release. |
|
Nice addition. Two things beyond @smnandre's comments: The paragraph "the documentation is wrong and gets fixed... Twig is fixed instead" can excuse any bugfix as a "doc fix". Needs a tighter scope or one example. Node classes are covered, tree shape is not. True but abstract. One small example would fix that. |
stof
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.