Speed up traversing nodes with node visitors - #4976
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeTraverserwalks the whole tree once per node visitor, and it iterated over the children of each node withforeach ($node as ...), which allocates anArrayIteratorper node and per visitor. It now reads the children array through a new internalNode::getNodes()method. On the Symfony Demo, where six visitors are registered, walking the 21k nodes of its 52 templates takes half the instructions it took, and warming up its Twig cache runs 15% fewer instructions and takes 520ms instead of 566ms.The traverser doesn't go through
getIterator()anymore, so a subclass overriding it to hide children from visitors would be bypassed, and one declaring its owngetNodes()would clash; I found none in Twig, Symfony or UX. CallinggetArrayCopy()on the iterator returned bygetIterator()would avoid the new method, but it saves 13% of the traversal instructions instead of 50%:new \ArrayIterator()andgetArrayCopy()both copy the array.Merge-up notes
To 4.x: the patch applies as is (I ran the 4.x suite with it), the CHANGELOG entry doesn't go to 4.x.