Skip to content

Fix the flaky health report size test - #375

Merged
txoof merged 1 commit into
mainfrom
374-flaky-health-test
Nov 9, 2026
Merged

txoof merged 1 commit into
mainfrom
374-flaky-health-test

Conversation

@txoof-bot

Copy link
Copy Markdown
Collaborator

Closes #374

What changed

The test test_report_is_replaced_and_never_grows failed now and then. It checked that the health file stays under 200 bytes, but one report line is already about 199–200 bytes, and its length changes with the process number and other numbers. The test now writes one report, notes the file's size, writes 199 more, and checks that the file is at most 10 bytes bigger than that first size. It still checks that the file is one line and that no temporary files are left.

This fix was meant to go into #373, but #373 was merged before it was pushed.

Area

core (tests only: tests/test_health.py)

Tests

Review

  • Review agents' comments answered

Only txoof approves and merges this PR.

🤖 Generated with Claude Code

…bytes

The report line is about 199-200 bytes and its length changes with the process number
and other numbers, so the old fixed limit failed now and then.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@txoof
txoof merged commit 4f282a3 into main Nov 9, 2026
3 of 4 checks passed
@txoof
txoof deleted the 374-flaky-health-test branch November 9, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: health report size check fails when the report is 200 bytes

2 participants