Repository navigation
Add functional service smoke coverage and fix CloudFront cleanup - #65
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulumi provisioning alone did not assert service behavior, and cleanup failures were discarded. Add
make smoke-serviceswith 30 exact SDK/HTTP cases across all 18 services,make smoke-regressionsfor workspace/native Lambda regressions, andmake smoketo run both plus Pulumi. The existing CI workflow now runs these checks against a freshly built server.New live regressions cover KMS secp256k1 sign/verify and invalid DIGEST errors with key IDs/ARNs, Lambda S3 code updates with changed hash/size readback, and CloudFront config read/disable/delete. Strict cleanup exposed malformed CloudFront GeoRestriction XML: Quantity was nested inside Items. Fix the wire shape and add a populated-location serializer regression. Cleanup errors now fail the smoke, retain diagnostic state, and also clean up partial deployments; provider retries are bounded for transient connection errors.
Validation on fresh local servers:
make smoke: workspace regressions, native Lambda tests, 30 functional cases, and base Pulumi provisioning/cleanup passed.make pulumi-hackathon-smokeandmake pulumi-commerce-smoke: passed, including deletion of all 26/223 resources.cargo build,cargo +nightly fmt --check,cargo clippy -- -D warnings, and targeted all-target Clippy passed.git diff --checkpassed.Coverage boundaries and recent-change mappings are documented in
docs/smoke-tests.md. Native Lambda execution tests use the provider/runtime path, while the public API smoke covers metadata/S3 code loading/DryRun; API Gateway uses MOCK, and SES asserts local API acceptance. Extra pedantic Clippy currently fails on pre-existing documentation lints in auth/Lambda model dependencies; standard warnings-as-errors checks pass.