Repository navigation
fix(sqs): accept MessageGroupId on standard queues - #71
Open
kylecannon wants to merge 1 commit into
Open
kylecannon wants to merge 1 commit into
kylecannon wants to merge 1 commit into
Conversation
Since SQS fair queues, standard queues take a MessageGroupId and hand it back on receive. rustack still rejected it as FIFO-only, so a client using fair queues failed on every send. Standard messages now keep their group id, and the id is validated the same way on both queue types (1-128 letters, digits and punctuation). FIFO queues weren't checking it before either. The dead-letter path used "has a group id" to mean "is FIFO", which would have kept grouped standard messages from ever reaching their DLQ. The source queue now passes its type along with the transfer. The sqs-compat test that expected the old rejection is flipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since SQS fair queues, standard queues take a
MessageGroupIdand hand it back on receive. rustack still rejected it as FIFO-only, so a client using fair queues failed on every send.MessageGroupIdattribute on receive.validate_message_group_id). FIFO queues weren't checking it before either.source_is_fifoonQueueCommand::Transfer).MessageDeduplicationIdis still rejected on standard queues.Test plan
cargo test -p rustack-sqs-coreand the SQS integration tests pass; sqs-compat passes with the flipped test.