Skip to content

Prettier, multiline userFilters in settings back up #4129

Description

@MorsMortium

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

I have my settings txt in a git repo. When exporting it, the userFilters becomes a single escaped line. It makes it very hard to compare the versions.

A specific URL where the issue occurs.

/dashboard.html#settings.html and /dashboard.html#1p-filters.html This is completely in the extension.

Steps to Reproduce

  1. Have a multi line filter list in my filters tab
  2. Export settings
  3. Inspect userFilters field in exported document

Expected behavior

That it keeps the lines separate, for example with userFilters becoming a list with each member being 1 line from the filter lists.

Troubleshooting information

uBlock Origin: 1.75.0
Firefox: 156
filterset (summary):
 network: 515692
 cosmetic: 426495
 scriptlet: 81404
 html: 4328
listset (total-discarded, last-updated):
 added:
  https://cdn.jsdelivr.net/gh/BevizLaszlo/UBlock-Filters-for-Social-Media@latest/filterlist.txt: 66-0, 5d.12h.3m
  ublock-experimental: 19-0, 52m Δ
  adguard-generic: 102378-5932, 3d.15h.47m
  adguard-mobile: 12853-101, 3d.15h.47m
  adguard-spyware-url: 2642-125, 6d.11h.57m
  block-lan: 91-0, 24d.11h.58m
  curben-phishing: 179451-50, 9h.6m
  adguard-cookies: 40543-117, 3d.15h.47m
  ublock-cookies-adguard: 5845-82, 6d.11h.57m
  fanboy-cookiemonster: 47920-4019, 1d.17h.42m
  ublock-cookies-easylist: 5845-5845, 6d.11h.57m
  adguard-social: 26960-45, 3d.15h.47m
  [51 lists not shown]: [too many]
 default:
  user-filters: 18-0, never
  ublock-filters: 54417-75, 52m Δ
  ublock-badware: 10155-17, 52m Δ
  ublock-privacy: 4143-2, 52m Δ
  ublock-unbreak: 2897-1, 52m Δ
  ublock-quick-fixes: 547-13, 52m Δ
  easylist: 89622-1375, 52m Δ
  easyprivacy: 56638-148, 52m Δ
  urlhaus-1: 46760-6, 9h.7m
  plowe-0: 3545-1463, 9d.2h.58m
filterset (user): [array of 18 redacted]
trustedset:
 added: [array of 9 redacted]
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 566 ms (selfie)
 maxAssetCacheWait: 306 ms
 cacheBackend: indexedDB

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfixedissue has been addressed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions