Repository navigation
Correct the documented default concurrency limit - #358
Merged
sidepelican merged 1 commit intoSep 8, 2026
Merged
Conversation
|
|
KYHyeon
force-pushed
the
feature/jamie/fix-concurrency-help
branch
from
August 12, 2026 10:36
9f290ca to
86b738b
Compare
KYHyeon
marked this pull request as ready for review
August 12, 2026 10:37
sidepelican
approved these changes
Sep 8, 2026
sidepelican
left a comment
sidepelican
left a comment
Collaborator
There was a problem hiding this comment.
Indeed, based on the implementation, it appears to default to 1.
This doesn't seem intentional, but since it has functioned this way for many years, we can consider the current implementation as the correct one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--concurrency-limithelp text to document the actual default of1.Background
concurrencyLimitis optional, and the scanner falls back to1when no value is provided. The existing help text incorrectly states that the default is the number of cores on the running machine.Testing
swift test.build/debug/mockolo --helpreports(default = 1).