Pass the precompile flag through to the backend installer - #623
Merged
Merged
Conversation
Previously `Zef::Install.install` accepted a `:$precompile` named argument but never forwarded it, so the backend installer always received an undefined `Bool` and `CompUnit::Repository::Installation.install` skipped precompilation entirely. As such nothing installed to an unnamed repository, e.g. `--to=inst#/some/path`, has been precompiled since 5d4cf5b. Installs to a named repository like `site` were unaffected because the staging workflow calls `.install` on the staging repository directly rather than going through this code path. This forwards the argument and defaults `:$precompile` to `True` on both `install` methods, so leaving it unspecified precompiles as the documentation already describes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
Zef::Install.installaccepted a:$precompilenamed argument but never forwarded it, so the backend installer always received an undefinedBoolandCompUnit::Repository::Installation.installskipped precompilation entirely. As such nothing installed to an unnamed repository, e.g.--to=inst#/some/path, has been precompiled since 5d4cf5b. Installs to a named repository likesitewere unaffected because the staging workflow calls.installon the staging repository directly rather than going through this code path.This forwards the argument and defaults
:$precompiletoTrueon bothinstallmethods, so leaving it unspecified precompiles as the documentation already describes.