feat: connect to hosts that are not in ssh_config - #28
Merged
Merged
Conversation
A typed user or port was parsed and then lost, so `:SSHConnect user@host` authenticated as the local user. Typed values now outrank what `ssh -G` reports, and the picker offers manual entry instead of dead-ending when ssh_config is empty. Closes #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
:SSHConnect user@hostparsed the user and then dropped it, so the connection authenticated as the local user, the original complaint in the issue. Typed values now outrank whatssh -Greports for the same name, since a typed user or port cannot have come from ssh_config. An alias still gains its full resolved config.The picker also offered no way to reach a host that is in no config: with an empty ssh_config it just said "No SSH hosts found" and stopped. It now prompts, and otherwise lists "Enter host manually..." alongside the configured hosts.
The issue also asked for error surfacing, failed-mount cleanup,
:SSHDebugand:SSHTest. Those issues were already resolved in #21, #22 and #23.