fix: clear RemoteCommand on every non-interactive path - #29
Merged
Merged
Conversation
OpenSSH refuses to run a config RemoteCommand alongside a command line, so batch auth failed before a mount was ever attempted, and sftp needs a plain session regardless. A bare terminal still honours the directive. Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
The failure is earlier than the issue describes.
build_batch_command,build_home_commandandbuild_auth_commandall append a command (exit,readlink -f $HOME ...), and OpenSSH refuses to run that alongside a configRemoteCommand:Cannot execute command-line and remote command.So authentication fails before a mount is attempted, which is why the host looks reachable everywhere except the mount.Those paths now pass
-o RemoteCommand=none, as does the ssh command handed to sshfs, since sftp needs a plain session.:SSHTerminalwithout a path still honours the directive; with a path it cannot, because thecdcollides the same way.Verified against a real config: without the flag ssh refuses outright, with it the command runs and fails only at DNS.
Note
-o RemoteCommand=noneonly wins because command-line options outrank config ones, it does not override an earlier-oon the same line.