test: keep the exit-hook specs off the real mount directory - #30
Merged
Merged
Conversation
setup() sweeps the configured base dir, so these specs unmounted whatever sat in the developer's ~/mnt. With every tool stubbed as present that meant spawning diskutil on Linux, and the suite passed or failed by machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two
automatic unmount on exitspecs callsshfs.setup(), which sweeps the configured mount base dir viaMountPoint.cleanup_stale. They also stubvim.fn.executableas true for everything while leavingvim.systemreal, so an empty leftover directory in the developer's~/mntmade the sweep spawndiskutil— absent on Linux — and the suite failed withENOENT: no such file or directory.Green on CI and on a clean
~/mnt, red otherwise. Reproduced with a singlemkdir ~/mnt/stale_probe, which flips the suite from 192 passed to 190 passed / 2 failed.Now points base_dir at a tempname and stubs
vim.system.