fix: refuse a forced tty where sftp and captured output run - #32
Merged
Merged
Conversation
RequestTTY force in ssh_config closes the sftp channel, so the mount fails with "remote host has disconnected", and a tty would also put carriage returns in the remote-home output. Interactive paths still get their tty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same class as #27, verified against a real sshd rather than reasoned about.
RequestTTY forcein ssh_config closes the sftp channel:sftpreportsConnection closedandsshfsfails withremote host has disconnected, never mounting. Adding-o RequestTTY=noto the ssh command mounts fine. A forced tty would also put carriage returns into the remote-homereadlinkoutput.Applied to the batch and socket paths only. Interactive authentication keeps its tty, since a password prompt needs one, as does
:SSHTerminal.Verified end to end with a user-level sshd on 127.0.0.1:2222 — mount fails with the directive, succeeds with the override.