Skip to content

Fixes for PLR0917 - #4577

Merged
clmould merged 9 commits into
ukaea:mainfrom
je-cook:PLR0917
Sep 10, 2026
Merged

Fixes for PLR0917#4577
clmould merged 9 commits into
ukaea:mainfrom
je-cook:PLR0917

Conversation

@je-cook

@je-cook je-cook commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Enables PLR0917

  • TODO fix calls

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook
je-cook requested a review from a team as a code owner September 2, 2026 11:15
@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.99%. Comparing base (bd5e644) to head (7222b21).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/cli.py 0.00% 1 Missing ⚠️
process/models/build.py 88.88% 1 Missing ⚠️
process/models/stellarator/neoclassics.py 91.66% 1 Missing ⚠️
process/models/tfcoil/base.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
+ Coverage   49.85%   49.99%   +0.14%     
==========================================
  Files         151      151              
  Lines       29875    29905      +30     
==========================================
+ Hits        14894    14952      +58     
+ Misses      14981    14953      -28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/models/stellarator/neoclassics.py Outdated
Comment thread process/models/tfcoil/base.py
Comment thread process/models/tfcoil/base.py Outdated
Comment thread process/models/tfcoil/base.py Outdated
Comment thread process/core/io/plot/scans.py Outdated
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
@clmould
clmould merged commit 4af0b03 into ukaea:main Sep 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants