Skip to content

Refactor fusion reactions for dataclass - #4592

Open
chris-ashe wants to merge 17 commits into
mainfrom
refactor_fus_reactions_dataclass
Open

Refactor fusion reactions for dataclass#4592
chris-ashe wants to merge 17 commits into
mainfrom
refactor_fus_reactions_dataclass

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

…aged' terminology for consistency across the codebase
…aged' terminology for consistency across the codebase
…ed' terminology for consistency across the codebase
…minology for consistency across the codebase
…ons classes for improved modularity and clarity in calculations
…lasmaReactions class for improved organization and clarity
@chris-ashe chris-ashe added Physics Relating to the physics models Refactor Variable rename labels Sep 10, 2026
…terminology for consistency across the codebase
@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 39.64758% with 137 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.12%. Comparing base (4618fd4) to head (4b99c28).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
process/models/physics/fusion_reactions.py 34.00% 99 Missing ⚠️
process/core/io/plot/summary.py 0.00% 22 Missing ⚠️
process/models/physics/physics.py 20.00% 12 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4592      +/-   ##
==========================================
+ Coverage   49.91%   50.12%   +0.21%     
==========================================
  Files         151      151              
  Lines       29860    29937      +77     
==========================================
+ Hits        14904    15007     +103     
+ Misses      14956    14930      -26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…wer density variables and update related calculations for consistency
…minology for consistency across plasma reactions and related calculations
@chris-ashe
chris-ashe marked this pull request as ready for review September 11, 2026 09:27
@chris-ashe
chris-ashe requested a review from a team as a code owner September 11, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Physics Relating to the physics models Refactor Variable rename

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants