Limestone rewrite - #46
Conversation
e75f573 to
e3c7ccb
Compare
|
To do:
|
|
Fixes #57 |
nrsa222
left a comment
There was a problem hiding this comment.
@Nealium104 - Great job, this is a major frontend update that makes the application look and feel like a part of the larger UK web presence. It fixes many accessibility issues and has improved the code base in a significant way. I left one accessibility suggestion but will approve this PR.
There was a problem hiding this comment.
For better accessibility, the button text should allow users to determine it's purpose from button text alone. I've found a good rule of thumb is to have action verb + noun, describing what the button does. In this specific case, I would just match the aria-label text.
nrsa222
left a comment
There was a problem hiding this comment.
Previous review was dismissed inadvertently when I pulled main into this branch to resolve a minor merge conflict.
Related to this exploreuk-web-app PR, this pull request is a full UI rewrite of the findingaid. This rewrite is primarily for addressing accessibility concerns.
This PR fixes #7, fixes #8, fixes #9, fixes #10, fixes #22, fixes #24, fixes #33, fixes #34, fixes #35, fixes #26, fixes #57, fixes #58.