Accept normalized CLA signature comments - #52
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
1 similar comment
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the complete .github/workflows/cla.yml diff and surrounding workflow behavior. The change is scoped to the signature trigger, preserves exact recheck handling, and does not create a CLA-signing bypass because signature validation remains owned by the action. LGTM.
|
🎉 PR #52 has been merged—thank you, @glenn-jocher, for the contribution!
This update makes CLA comments with surrounding whitespace or Markdown eligible for normalized signature validation, while keeping |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow to pass comments containing the standard CLA signature text to the normalized signature matcher, while keeping
recheckmatching exact.📊 Key Changes
contains(...)in.github/workflows/cla.yml.recheckcommand still requires an exact comment match.🎯 Purpose & Impact