Repository navigation
Conversation
…ne change A pin update alone keeps a stale pm-github-version as an explicit hold, so the caller would keep installing the older extension (now with a warning). The caller inventory and the README migration note now say to make both edits atomically. (CodeRabbit, docs/workflow-version-callers.md:6)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Reviewer's GuideAPIExpose PR, registered CI run, parked-run, and confirmation outputs from both reusable workflows as the handoff contract.
Change extension-version resolution so the reusable workflow manifest selects the default, explicit inputs remain warned holds, and registry preflight blocks writes for unavailable packages.
ImplementationDispatch caller CI while recording dispatch context and parked-run snapshots, then confirm run appearance under a bounded shared deadline without waiting for completion.
ConfigurationRegenerate the identity-ownership inventory anchor after the workflow edits shifted the referenced line.
DocumentationExplain the runner-release receipt contract, its migration, version selection, and the caller inventory that must drop explicit holds when updating pins.
Record the fixes and move the runner-cost item into the unreleased changelog section.
TestsUpdate workflow behavior checks for closeout attribution holds and exercise the registration receipt’s matching, outputs, timeout, and failure semantics.
Replace tag-based version tests with manifest, explicit-hold, registry-preflight, and tracker-write safety coverage.
Other changesFiles not grouped.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
 [Medium impact] The reviewed follow-up appears safe to merge. SummarySync and closeout now report bounded CI registration receipts without waiting for checks to finish. This follow-up refreshes the generated ownership inventory and records validation results.
No new actionable issues were found in the changes since the previous review. Reviews (3) · Last reviewed commit: "fix: merge workflow inventory repair and..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Independent check on This stack does inherit the ownership inventory failure from #245, but the anchor moves again: |
|
Follow-up on the same The two real stuck-lookup controls also hit the outer ~30-second fixture limit ( |
The reusable sync and closeout jobs must release their runner while caller CI runs. Historical fleet runs averaged about 85 runner-minutes; one measured sync finished its real work in 44 seconds and then polled for two hours. #229 already removed that completion loop; this completes the bounded dispatch receipt and reporting contract.
Built on #245's head (
a69388d2d93ba15fd8f22840f3b9c8780c78f36a) while it was open. Merge #245 first; callers only need the workflow pin bump from the #238 sweep.timed_outwithout failing sync or revoking auto-merge. Genuine dispatch failures still fail before arming.pm-github-sgyr.Expected ordinary duration: under two minutes for the measured 44-second workload plus at most 60 seconds of registration discovery. This is a budget/expectation, not a new live fleet timing measurement.
Validation:
node --test --test-concurrency=2 test/ci-handoff-workflow.test.ts test/bot-pr-workflow.test.ts test/self-versioned-workflows.test.ts test/workflow-rule-names.test.ts test/daily-sync-alert.test.ts: 199/199 passed.NPM_CONFIG_USERCONFIG=/dev/null node --test --test-concurrency=2 --test-name-pattern="workflow credentials|earlier armed auto-merge|informational parked-run failure|previous auto-merge is revoked on workflow exit: maintenance" test/import-gate.test.ts test/closeout-workflow.test.ts: 4/4 passed after build.bun test --timeout 120000 test/ci-handoff-workflow.test.ts: 21/21 passed; the full updated Node workflow group also passed through pinnedpm test --run --progress.npm run build,npm run typecheck,npm run build:test,npm run lint,npm run privacy,npm run docstring,npm run verify:release-publish-attestation,npm run changelog:fullandnpm run changelog:check: passed.actionlintis unavailable.6ccb293; the new every-reusable-step contract fails independently for sync and closeout (one failure each). Restore the fixed workflows and the contract passes. Missing, denied, timed-out and partial registration all return success and an informational timeout receipt.Tracker: pm-github-fxhd, reused for #228 and left in progress for orchestrator verification. README and migration notes document the handoff and pin-only adoption.
Additional review evidence at
8090147f1716883c9f35ac0de904517a0c22d6f4: controlled-clock cases exhaust the shared deadline across workflow lookups and forbid a late third lookup while retaining partial URLs. Real GNU timeout cases kill a genuinely stuck lookup after ten seconds and report successful informational timeout receipts. Removing the admission guard or shortening the real timeout independently fails the corresponding behavioral tests (four expected failures across sync/closeout).Review thread
PRRT_kwDOTbN4pM63g99s/ comment4574827470is addressed by test commit8090147f1716883c9f35ac0de904517a0c22d6f4; it is left open for orchestrator response, with no thread reply, resolution or reaction.Final-head CI: CI, CodeQL. Both are queued at handoff preparation. The original bounded CI cutoff is retained; pending checks are not certification.
Summary by Sourcery
Release sync and closeout runners after dispatch by replacing completion polling with bounded CI registration receipts and safer workflow-version resolution.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores:
Summary by cubic
Stops the gated sync and closeout workflows from holding a runner while caller CI runs. They now confirm that caller runs appeared within one 60-second budget, then report their URLs and status without polling for completion.
timed_outwithout failing sync, closeout, or arming auto-merge.pm-github-version; explicit version holds still install the requested version but warn when it differs.Migration: Callers must move the workflow pin to a release containing #238 and remove
pm-github-versionin the same change, since a pin update alone keeps stale inputs as explicit holds.docs/no-ci-polling-migration.mdanddocs/workflow-version-callers.mdcover adoption.Written for commit a713004. Summary will update on new commits.