Repository navigation
Conversation
Replace gopkg.in/ini.v1 with unknwon.dev/ini/v2. The value mapper is now passed as a load option instead of set on the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
gopkg.in/ini.v1v1.67.2 withunknwon.dev/ini/v2v2.0.0-beta.4.Only
cmd/lfsd/config.gouses the package. The one API change that affects it isFile.ValueMapper, which v2 replaces with theini.ValueMappingload option, soos.ExpandEnvis now passed toini.Load.[storage "..."]and[forge "..."]sections are now read withFile.Subsectionsinstead of hand-parsing section names. This also accepts the dotted form, such as[forge.github.com], and\"escapes in quoted names. A malformed header such as[storage "local]is now skipped instead of failing with "malformed storage section name".Test plan
go build ./...,go test ./...andgolangci-lint runpass.${VAR}expansion (including a value containing#), custom overrides,%(ROOT)sreferences, and forge and storage sections map as before.[forge "GitHub.com"],[forge.gitlab.example.com]and[storage "s3 \"x\""]all load, and that[forge "a.com"]plus[forge.a.com]is reported as a duplicate.