Repository navigation
Conversation
…k it
no-positive-tabindex only accepts literal values (or if/unless with literal
branches), so `tabindex={{this.optionLabelTabIndex}}` failed lint:hbs. Same
values as before: -1 when disabled, 0 otherwise.
…board operable When the content is truncated the root element gets role="button", but it could not be focused or toggled from the keyboard, which is what no-invalid-interactive reported. It now also gets tabindex="0" and toggles on Enter and Space. Short or non-collapsible feedback is unchanged: no role, no tabindex, keys are ignored.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the two
ember-template-linterrors on master. Master's CI only runslint:js, so they went unnoticed, but they faillint:hbsand therefore the "Lint & Typecheck" job of #719, which runs the fullpnpm lint.OSS::ModeSwitch(no-positive-tabindex, from 87bd9d4): the rule only accepts literal tabindex values, so the label now usestabindex={{if @disabled "-1" "0"}}instead of theoptionLabelTabIndexgetter. Same values as before.OSS::Smart::Feedback(no-invalid-interactive, from 738e330): when the content is truncated, the root element getsrole="button"but could not be focused or toggled from the keyboard. It now also getstabindex="0"and toggles on Enter and Space. Short or non-collapsible feedback is unchanged.What are the observable changes?
Good PR checklist