Skip to content

fix: detect function calls in default argument values (#304) - #360

Open
bburns632 wants to merge 1 commit into
mainfrom
fix/formals-dependencies-304
Open

bburns632 wants to merge 1 commit into
mainfrom
fix/formals-dependencies-304

Conversation

@bburns632

Copy link
Copy Markdown
Collaborator

Closes #304.

Problem

FunctionReporter only parsed body() of each function, so calls made inside default argument values produced no edge in the function network:

ParseGruffiGranuleScoreName <- function(goID, obj = combined.obj, granuleRes = GetGruffiClusteringName(obj)) {
  Stringendo::kppu(granuleRes, "cl.av", make.names(goID))
}
# no edge to GetGruffiClusteringName

Fix

  • New helper .parse_closure() parses both body(fn) and formals(fn). .called_by() now uses it.
  • .determine_R6_dependencies() also parses the method's formals(), so R6 methods with defaults like y = self$other() or x = helper() get their edges.

.parse_function() / .parse_R6_expression() already handle formals() output (pairlists, including arguments with no default), so the parsers themselves are unchanged.

Tests

  • .parse_closure finds calls in both defaults and body
  • .called_by creates edges for calls in default arguments (the scenario from the issue)
  • .parse_R6_expression finds calls in R6 method defaults

R CMD check --as-cran with NOT_CRAN=true: 267 passed, 0 failed (263 on main + 4 new). No existing fixture-package expectations changed.

🤖 Generated with Claude Code

FunctionReporter only parsed body() of each function, so calls made in
default argument values (e.g. function(x, y = helper(x))) produced no
edge. Parse formals() as well, for both regular functions and R6 methods.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bburns632
bburns632 force-pushed the fix/formals-dependencies-304 branch from 3a0b207 to 3714990 Compare November 16, 2026 03:05
@bburns632
bburns632 requested review from jameslamb and jayqi November 16, 2026 03:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing dependency link, if function call happens within the arguments of a function

1 participant