Skip to content

server: add grpc_recovery.go and its test to BUILD.bazel - #67

Merged
shreyas-blacksmith merged 4 commits into
patchsetfrom
rcooney-sh/server-build-grpc-recovery
Oct 27, 2026
Merged

shreyas-blacksmith merged 4 commits into
patchsetfrom
rcooney-sh/server-build-grpc-recovery

Conversation

@rcooney-sh

@rcooney-sh rcooney-sh commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

patchset doesn't build under Bazel: server/BUILD.bazel doesn't list grpc_recovery.go (added in #65). The v2.6.1-blacksmith.14 release build failed on every platform with:

main.go:540:57: undefined: server.GRPCRecoveryStreamServerInterceptor
main.go:541:55: undefined: server.GRPCRecoveryUnaryServerInterceptor

Since #66, the server library fails first (grpc_bytestream.go: undefined: recoveredPanicStatus). PR CI runs go test, which ignores BUILD files, so only the Bazel release build catches this.

This change adds grpc_recovery.go to go_library, and adds the crafted-frame test and #66's put-panic test to go_test, all in gazelle order. They need no new deps. config/proxy_test.go has the same gap but is unrelated to this fix, so it is left for a separate change.

The .14 tag points at the broken commit and has no binaries. Once this merges, the release should be cut again as v2.6.1-blacksmith.15.

Matches Bazel release build compiles

Before, the build fails in the server library on undefined recoveredPanicStatus as the PR now says; after, it builds.

Merge-base

Bazel build before

This PR 270f0445

Bazel build after

Also checked · 3 match

Matches Crafted-frame test runs under Bazel
Matches Put-panic test runs under Bazel
Matches BUILD entries in gazelle order

Proof on 270f0445 (from f5a22aa2)

View full Proof report

codesmith-bot and others added 4 commits October 27, 2026 01:47
Merges patchset (#66) into this branch so the Bazel test target covers every
_test.go in server/ and the release build compiles from the current patchset head.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@shreyas-blacksmith
shreyas-blacksmith merged commit f3ea996 into patchset Oct 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants