Repository navigation
server: add grpc_recovery.go and its test to BUILD.bazel - #67
Merged
shreyas-blacksmith merged 4 commits intoOct 27, 2026
Merged
Conversation
Merges patchset (#66) into this branch so the Bazel test target covers every _test.go in server/ and the release build compiles from the current patchset head. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patchsetdoesn't build under Bazel:server/BUILD.bazeldoesn't listgrpc_recovery.go(added in #65). Thev2.6.1-blacksmith.14release build failed on every platform with:Since #66, the server library fails first (
grpc_bytestream.go: undefined: recoveredPanicStatus). PR CI runsgo test, which ignores BUILD files, so only the Bazel release build catches this.This change adds
grpc_recovery.gotogo_library, and adds the crafted-frame test and #66's put-panic test togo_test, all in gazelle order. They need no new deps.config/proxy_test.gohas the same gap but is unrelated to this fix, so it is left for a separate change.The
.14tag points at the broken commit and has no binaries. Once this merges, the release should be cut again asv2.6.1-blacksmith.15.Before, the build fails in the server library on undefined recoveredPanicStatus as the PR now says; after, it builds.
Merge-base
This PR
270f0445Also checked · 3 match
Proof on
270f0445(fromf5a22aa2)View full Proof report