chore: allow utopia-php/console 0.2 - #965
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Composer dependency constraint for ChangesConsole dependency compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The constraint now permits console 0.2.x while preserving existing 0.1.x installs, allowing consumers to upgrade independently. No concrete production-impacting risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| "ext-redis": "*", | ||
| "utopia-php/validators": "^1.0", | ||
| "utopia-php/console": "0.1.*", | ||
| "utopia-php/console": "0.1.* || 0.2.*", |
There was a problem hiding this comment.
The newly supported 0.2.* line is not exercised by CI because the existing jobs install the lock file, which still resolves utopia-php/console 0.1.1. This means regressions in the Console::warning() and Console::error() behavior used by this library could pass unnoticed. Add a behavioral CI job that resolves console 0.2 and runs the normal test suite rather than asserting the version constraint itself.
Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 42
Comment:
**Console 0.2 remains untested**
The newly supported `0.2.*` line is not exercised by CI because the existing jobs install the lock file, which still resolves `utopia-php/console` 0.1.1. This means regressions in the `Console::warning()` and `Console::error()` behavior used by this library could pass unnoticed. Add a behavioral CI job that resolves console 0.2 and runs the normal test suite rather than asserting the version constraint itself.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.console 0.2 only adds Utopia\Command and keeps the whole 0.1 Console surface this library uses, so both lines are accepted instead of forcing consumers to move together. Lock content hash refreshed; resolved versions are unchanged. Supersedes #882. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
f4503d5 to
fdbb112
Compare
Summary
utopia-php/consolefrom0.1.*to^0.1 || ^0.2.Utopia\Commandand keeps the whole 0.1Consolesurface this library uses (three call sites insrc/), so accepting both lines lets consumers upgrade independently instead of forcing every 0.1 consumer to move at once.composer.lockchanges by content hash only; resolved versions are unchanged.Appwrite is moving to console 0.2 for structured command execution and currently has to alias
0.2.9 as 0.1.1because of this pin.Supersedes #882, which hard-bumps to
0.2.*from a base that predates the cache 5 and validators 1.0 bumps.Testing
composer update --lock(no version changes)🤖 Generated with Claude Code