Skip to content

feat(analytics): 멤버 초대 발급 권한과 방 수정 성공 계측 반영 - #227

Merged
minbros merged 1 commit into
devfrom
feature/member-permission-events-tfba60120
Oct 10, 2026
Merged

minbros merged 1 commit into
devfrom
feature/member-permission-events-tfba60120

Conversation

@minbros

@minbros minbros commented Oct 10, 2026

Copy link
Copy Markdown
Member

변경 내용

  • 새 화면이나 디자인 추가 없이 활성 HOST/MEMBER가 기존 초대 코드 발급·재발급 UI를 사용할 수 있도록 했습니다.
  • 명시적 발급과 방 정보 저장 성공을 Amplitude 전용 이벤트로 기록합니다. 역할·방 그룹을 유지하고 자동 fallback, 실패, 중복 클릭 및 계정·방·동의 변경에 따른 잘못된 귀속을 막습니다.
  • 기존 공유 동작과 다른 방장 전용 권한을 유지하고 회귀 테스트·분석 문서를 갱신했습니다.

변경 이유

  • 멤버 권한 확대를 기존 UI와 성공 이벤트 계측에 일치시킵니다.

테스트

  • npm run lint — 오류 0, 변경하지 않은 파일의 기존 경고 4개
  • npm test — 전체 1,357개 통과 후 테스트 하네스만 정리했고, 관련 18개를 재검증했습니다. 최종 커밋의 전체 재실행은 하지 않았습니다.
  • npm run build — 합성 로컬 환경변수로 성공
  • 그 외 수동 검증: 실제 로컬 로그인과 격리 DB의 MEMBER 재발급 저장·기존 패널 화면 확인
  • 최초 발급 fallback 실동작, 모바일·전체 QA, 방 정보 UI 저장 및 운영 이벤트 수신은 미검증입니다.

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frontend-server Ready Ready Preview Oct 10, 2026 11:05am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c97dbab-3d3a-40f1-aa24-5ed4717702a1

📥 Commits

Reviewing files that changed from the base of the PR and between 2db8041 and 306ca03.


📒 Files selected for processing (16)
  • docs/analytics/amplitude-operations.md
  • docs/analytics/amplitude-tracking-plan.md
  • src/app/(main)/member-settings/_components/AddMemberPanel.analytics.test.tsx
  • src/app/(main)/member-settings/_components/AddMemberPanel.tsx
  • src/app/(main)/member-settings/_components/RoomMembersSection.tsx
  • src/app/home/_components/RoomCardMenu.test.tsx
  • src/components/layout/HeaderMemberPreview.tsx
  • src/components/rooms/RoomTripEditForm.test.tsx
  • src/components/rooms/RoomTripEditForm.tsx
  • src/hooks/useRooms.analytics.test.tsx
  • src/hooks/useRooms.ts
  • src/lib/analytics/event-destinations.ts
  • src/lib/analytics/event-routing.test.ts
  • src/lib/analytics/room-events.ts
  • src/lib/analytics/room-mutation.ts
  • src/lib/analytics/track.ts

 _______________________________________________
< Caches are bugs waiting to happen. - Rob Pike >
 -----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@minbros
minbros merged commit 56fef69 into dev Oct 10, 2026
4 of 5 checks passed
@minbros
minbros deleted the feature/member-permission-events-tfba60120 branch October 10, 2026 11:08

This branch was successfully deployed

1 active deployment
Preview — 306ca03f Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant