Skip to content

chore(deps): update rust crate dns-lookup to v4 - #14194

Merged
cakebaker merged 1 commit into
mainfrom
renovate/dns-lookup-4.x
Aug 29, 2026
Merged

chore(deps): update rust crate dns-lookup to v4#14194
cakebaker merged 1 commit into
mainfrom
renovate/dns-lookup-4.x

Conversation

@renovate

@renovate renovate Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
dns-lookup workspace.dependencies major 3.0.04.0.0

Release Notes

keeperofdakeys/dns-lookup (dns-lookup)

v4.0.1

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 361 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing renovate/dns-lookup-4.x (da30179) with main (a45e6d9)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (96c44c2) during the generation of this report, so a45e6d9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@xtqqczze

Copy link
Copy Markdown
Contributor
error[E0599]: no method named `map_err_context` found for enum `Result<T, E>` in the current scope
   --> src/uu/hostname/src/hostname.rs:142:18
    |
141 |               let addrs: Vec<std::net::IpAddr> = lookup_host(hostname.as_str())
    |  ________________________________________________-
142 | |                 .map_err_context(|| "failed to lookup hostname".to_owned())?
    | |                 -^^^^^^^^^^^^^^^ method not found in `Result<impl Iterator<Item = IpAddr>, LookupError>`
    | |_________________|

@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@lcheylus I'd like to remove this crate from dep tree which is used only for *BSD. Is the comment

// DNS reverse lookup via "hostname:1" does not work on FreeBSD and OpenBSD
// use dns-lookup crate instead

still valid on modern *BSD's?

@lcheylus

Copy link
Copy Markdown
Contributor

@oech3 Why do you want to remove this crate?

Yes, the dns-lookup crate is necessary on *BSD to do reverse DNS lookup in hostname tool.

@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Because we don't want to audit too many external crates. This crate is used just once. Can we implement necessary part by ourself?

@lcheylus

Copy link
Copy Markdown
Contributor

Yes, lookup_host function from dns-lookup crate used in hostname tool could be reimplemented for BSD instead of using this crate.

Code for loookup_host function here => https://github.com/keeperofdakeys/dns-lookup/blob/master/src/lookup.rs#L22

@xtqqczze

Copy link
Copy Markdown
Contributor

We should check whether the ToSocketAddrs implementation works on freebsd, since both it and the dns-lookup implementation ultimately wrap getaddrinfo.

@xtqqczze

Copy link
Copy Markdown
Contributor

Let's see: #14198

@renovate
renovate Bot force-pushed the renovate/dns-lookup-4.x branch from b749a2d to da30179 Compare August 28, 2026 13:40
@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Why not closed automatically?

@cakebaker

Copy link
Copy Markdown
Contributor

@oech3 it is still used in uucore/utmpx.

@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

oops

@xtqqczze

Copy link
Copy Markdown
Contributor

We can't use std::net::ToSocketAddrs in uucore/utmpx as we need the AI_CANONNAME flag for canonical DNS resolution.

@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

How about using nix or libc?

@xtqqczze

Copy link
Copy Markdown
Contributor

dns-lookup is a wrapper for libc, I think we should upgrade to v4 for now.

@oech3

oech3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

We can still drop socket2.

@cakebaker
cakebaker merged commit 6e01385 into main Aug 29, 2026
182 checks passed
@cakebaker
cakebaker deleted the renovate/dns-lookup-4.x branch August 29, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants