stty: verify tcsetattr applied all requested settings - #14196
Open
MadeNavaneeth wants to merge 1 commit into
Open
stty: verify tcsetattr applied all requested settings#14196MadeNavaneeth wants to merge 1 commit into
MadeNavaneeth wants to merge 1 commit into
Conversation
POSIX allows tcsetattr to succeed while only partially applying changes. GNU stty re-reads terminal settings after tcsetattr and compares them to the requested configuration, exiting with an error if they differ. uutils previously called tcsetattr and returned success without verification. Fixes uutils#10324
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10324
POSIX allows
tcsetattrto succeed while only partially applying requested changes. GNU stty re-reads terminal settings aftertcsetattrand compares them to the requested configuration, exiting with an error if they differ.Previously, uutils called
tcsetattrand returned success without verification, which could silently leave the terminal misconfigured (e.g., scripts disabling echo for password input).This adds a readback-and-compare step after
tcsetattr, matching GNU behavior.