ln: avoid accessing by index & simplify if - #14197
Merged
Merged
Conversation
sylvestre
enabled auto-merge (rebase)
August 28, 2026 07:35
Contributor
|
Is it really better? |
Contributor
Author
|
match clarifies they does not happen at the same time & avoid using out of range.
|
|
GNU testsuite comparison: |
Contributor
|
Conflicts with #12257, please convert to draft. |
xtqqczze
reviewed
Aug 28, 2026
| return Err(LnError::ExtraOperand( | ||
| files[2].clone().into(), | ||
| match files { | ||
| [] => unreachable!("clap excluded it"), |
Contributor
There was a problem hiding this comment.
exec is a public API, we cannot say clap excluded this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.