tail: replace same-file with rustix and drop the dependency - #14208
Merged
Conversation
oech3
reviewed
Aug 28, 2026
| // cannot be applied under these circumstances and is therefore ineffective. | ||
| if self.follow.is_some() && self.has_stdin() { | ||
| #[cfg(unix)] | ||
| let stdin_is_not_regular = rustix::fs::fstat(std::io::stdin().as_fd()) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wtcpython
force-pushed
the
remove-same-file
branch
from
August 28, 2026 14:43
fa758d4 to
58c3031
Compare
|
GNU testsuite comparison: |
Contributor
|
Three intermittents with tail, not sure it is a coincidence |
sylvestre
force-pushed
the
remove-same-file
branch
from
August 29, 2026 09:18
58c3031 to
8970e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the external
same-filedependency inuu_tailwithrustix::fs::fstatandrustix::fs::telland remove it from the workspace.