Repository navigation
chore: upgrade Highcharts to 12.6.2 in the SVG generator - #10520
Draft
totally-not-ai[bot] wants to merge 3 commits into
Draft
totally-not-ai[bot] wants to merge 3 commits into
totally-not-ai[bot] wants to merge 3 commits into
Conversation
Highcharts 12.3 removed Chart#sanitizeSVG, so use the static Exporting.sanitizeSVG instead. Regenerate the expected SVGs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Highcharts 12.6.1 and 12.6.2 reject reserved point key segments and filter credits and xlink:href links through the AST allow list. Remove the duplicate patches and their tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
totally-not-ai
Bot
changed the title
Restore the point key, credits link and xlink:href tests, which assert outcomes rather than the removed patches. Credits links outside the Highcharts allow list, such as about.html or tel:, are now ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review risk: two-way door — Charts SVG generator (server-side SVG export) only
Description
Upgrades
highchartsinvaadin-charts-flow-svg-generatorfrom 12.2.0 to 12.6.2, matching@vaadin/charts(vaadin/web-components#13289). Highcharts backports fixes, including security fixes, only to its latest minor version.Part of vaadin/web-components#12983
Chart#sanitizeSVG;jsdom-exporter.jsnow uses the staticHighcharts.Exporting.sanitizeSVG(svg, chart.options). Without this the exporter fails withchart.sanitizeSVG is not a function.src/test/resources(Highcharts version string and minor rendering differences).highcharts-patches.jsthat 12.6.1/12.6.2 now include (setNestedProperty,addCredits,AST.filterUserAttributesforxlink:href). Their tests stay, so they now check the fixes Highcharts ships.optionsToObjectand_defaultSetterstay.Behavior change:
credits.hrefnow only accepts links matchingAST.allowedReferences(https://,http://,mailto:,/,./,../,#). A vertical heatmap color axis is no longer reversed (colorAxis.reversed: truerestores it), and some Charts screenshots may shift by 1 px.Type of change
Checklist
Test summary
SVGGeneratorTestpass locally with Node 24.🤖 Generated with Claude Code