Skip to content

Fix singleargo secret copying - #841

Open
mbaldessari wants to merge 1 commit into
validatedpatterns:mainfrom
mbaldessari:fix-single-argo-secret
Open

mbaldessari wants to merge 1 commit into
validatedpatterns:mainfrom
mbaldessari:fix-single-argo-secret

Conversation

@mbaldessari

Copy link
Copy Markdown
Contributor

To do this we actually parse the set of value files (and extraParams) and
we verify if global.singleArgoCD is true or not.

If it is true there is no need to copy the git secret to the namespaced
argo instance as there is only a single "clusterwide" argo instance.

Tested as follows:

    1. No secrets public repo single argo  -> OK
    2. No secrets public repo multi argo   -> OK
    3. One secret private repo single argo -> OK
    ```
    ./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
    ```

    4. One secret private repo multi argo  -> OK
    ```
    ./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
    ```

Fixes: #838

@openshift-ci
openshift-ci Bot requested review from beekhof and darkdoc September 28, 2026 14:20
@openshift-ci

openshift-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaldessari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

To do this we actually parse the set of value files (and extraParams) and
we verify if global.singleArgoCD is true or not.

If it is true there is no need to copy the git secret to the namespaced
argo instance as there is only a single "clusterwide" argo instance.

Tested as follows:

        1. No secrets public repo single argo  -> OK
        2. No secrets public repo multi argo   -> OK
        3. One secret private repo single argo -> OK
        ```
        ./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
        ```

        4. One secret private repo multi argo  -> OK
        ```
        ./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
        ```

Fixes: validatedpatterns#838
@mbaldessari
mbaldessari force-pushed the fix-single-argo-secret branch from 04ca400 to 1da6ad4 Compare September 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

patterns-operator copies git auth secret into Application *name* as a *namespace* (breaks singleArgoCD + tokenSecret)

1 participant