Fix singleargo secret copying - #841
Open
mbaldessari wants to merge 1 commit into
Open
mbaldessari wants to merge 1 commit into
mbaldessari wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To do this we actually parse the set of value files (and extraParams) and
we verify if global.singleArgoCD is true or not.
If it is true there is no need to copy the git secret to the namespaced
argo instance as there is only a single "clusterwide" argo instance.
Tested as follows:
1. No secrets public repo single argo -> OK
2. No secrets public repo multi argo -> OK
3. One secret private repo single argo -> OK
```
./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
```
4. One secret private repo multi argo -> OK
```
./pattern.sh make TARGET_ORIGIN=mcg-private-http TOKEN_SECRET=private-repo TOKEN_NAMESPACE=openshift-operators install
```
Fixes: validatedpatterns#838
mbaldessari
force-pushed
the
fix-single-argo-secret
branch
from
September 28, 2026 15:51
04ca400 to
1da6ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this we actually parse the set of value files (and extraParams) and
we verify if global.singleArgoCD is true or not.
If it is true there is no need to copy the git secret to the namespaced
argo instance as there is only a single "clusterwide" argo instance.
Tested as follows:
Fixes: #838