Skip to content

Address colored output being broken due to new build system - #248

Merged
gwynne merged 11 commits into
mainfrom
gwynne-patch-1
Oct 19, 2026
Merged

gwynne merged 11 commits into
mainfrom
gwynne-patch-1

Conversation

@gwynne

@gwynne gwynne commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

These changes are now available in 5.0.0-beta.3

Swift 6.4 enables the new Swift build system by default. Since that build system always sets Xcode (see swiftlang/swift-package-manager#10675), we can no longer use that to detect Xcode. Switch to detecting whether the TERM env var is set to dumb instead, which is arguably a more accurate check anyhow.

Fixes #247.

@gwynne gwynne added the semver-patch When merged, a new patch version release will be generated label Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.37%. Comparing base (5acfda6) to head (9a21308).

Files with missing lines Patch % Lines
Sources/ConsoleKit/Terminal/Terminal.swift 0.00% 2 Missing ⚠️
...ConsoleLogger/LoggerFragments/LoggerFragment.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #248       +/-   ##
===========================================
+ Coverage   71.86%   82.37%   +10.51%     
===========================================
  Files          29       29               
  Lines         878      891       +13     
===========================================
+ Hits          631      734      +103     
+ Misses        247      157       -90     
Files with missing lines Coverage Δ
Sources/ConsoleKit/Terminal/Console.swift 100.00% <100.00%> (ø)
...ConsoleLogger/LoggerFragments/LoggerFragment.swift 91.39% <80.00%> (-0.40%) ⬇️
Sources/ConsoleKit/Terminal/Terminal.swift 50.00% <0.00%> (+26.31%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xTim 0xTim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to back port this to v4 as well

@gwynne

gwynne commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

API breakage checker failure is spurious.

Backported in #249.

@gwynne
gwynne merged commit df9e94c into main Oct 19, 2026
21 of 26 checks passed
@gwynne
gwynne deleted the gwynne-patch-1 branch October 19, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch When merged, a new patch version release will be generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colored output no longer works as of swift 6.4

2 participants