Repository navigation
Fix Missing Connection Metadata - #232
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 64.36% 65.09% +0.72%
==========================================
Files 12 12
Lines 609 616 +7
==========================================
+ Hits 392 401 +9
+ Misses 217 215 -2
🚀 New features to boost your workflow:
|
ptoffy
requested changes
Sep 29, 2026
ptoffy
left a comment
ptoffy
left a comment
Member
There was a problem hiding this comment.
We should not be using PostgresDatabase anymore
0xTim
commented
Sep 29, 2026
| let encodingContext: PostgresEncodingContext<E> | ||
| let decodingContext: PostgresDecodingContext<D> | ||
| let inTransaction: Bool | ||
| let connection: PostgresConnection? |
Member
Author
There was a problem hiding this comment.
We had to add this to avoid a crash in withConnection in a transaction
Member
There was a problem hiding this comment.
We don't need this, Sorry, I was on mobile and misread. Only the FluentPostgresClientDatabase should use the new .sql method taking a logger. The current FluentPostgresDatabase can stay as it is, with the new major it will be deprecated along with PostgresDatabase
ptoffy
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 2.14.1
Resolves #230
The only metadata that is set in the stack is the connection ID, so make sure we copy that over into a new logger. Can't do the other way around in case we pollute other loggers. I'll be glad when we can remove all these hacks and just use task locals...