Repository navigation
fix(catalog): retain the mirror artifact base during sync - #69
Closed
KennyMcSimpson wants to merge 1 commit into
Closed
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
|
@KennyMcSimpson is attempting to deploy a commit to the vastsa's projects Team on Vercel. A member of the Team first needs to authorize it. |
KennyMcSimpson
marked this pull request as ready for review
October 7, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Follow-up to #62: the committed catalog now declares
artifactBaseUrl, butrewrite_for_mirrorremoves it on the next sync. Serving that mirror catalog from another host then makes relative package URLs resolve against the wrong origin again.Keep the mirror's existing artifact base when syncing, including the legacy spelling, and declare this repository's raw GitHub base for a new mirror. Package downloads still use the source catalog's base; only the generated mirror points at
packages/here.Tests cover the default base, a custom mirror base, the legacy field, unchanged source input, and staged synchronization. No catalog or published package is changed in this PR.
Checks
python3 scripts/security_audit.py --check-packages— zero blockerspython3 -m unittest discover -s tests -p 'test_*.py' -v— 17 tests passedcatalog.jsonand published packages are unchangedplugins/) was addedpython3 scripts/sync_catalog.py --dry-runalso completed against the live center (52 plugins, 90 packages staged). No repository files were replaced.