Repository navigation
fix(website): resolve downloads against the catalog artifact base - #72
Closed
KennyMcSimpson wants to merge 1 commit into
Closed
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
|
@KennyMcSimpson is attempting to deploy a commit to the vastsa's projects Team on Vercel. A member of the Team first needs to authorize it. |
KennyMcSimpson
marked this pull request as ready for review
October 7, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
When
CATALOG_URLpoints at another host, the plugin detail page ignoresartifactBaseUrland builds the wrong download URL. For example,packages/pi.gitlens-0.2.7.piplugis resolved on the plugin-center host even when the catalog declares the raw GitHub mirror as its artifact base.Pass the loaded catalog to the download helper and resolve relative package paths against its artifact base. Keep absolute URLs unchanged and fall back to the catalog URL when no base is declared. The download link and copy button use the same resolved URL.
Add four URL-resolution tests using Node's built-in test runner, with no new dependencies. The test command needs Node.js 22.6 or later.
Checks
python3 scripts/security_audit.py --check-packages— zero blockerspython3 -m unittest discover -s tests -p 'test_*.py' -v— 15 tests passedcd website && pnpm test && pnpm build— four tests and production build passedcatalog.jsonand published packages are unchangedplugins/) was addedpython3 scripts/sync_catalog.py --dry-runalso completed against the live center (52 plugins, 90 packages staged). No repository files were replaced.